Hi all, Several ATA kernel modules depend on the legacy IDE interface CONFIG_ATA_SFF (e.g. kmod-ata-ixp4xx-cf). ATA_SFF needs to be set when kmod-ata-core builds. Currently ATA_SFF is set by some architectures.
Ixp4xx has CONFIG_ATA_SFF=y in ixp4xx/config-2.6.28. This is somehow lost and does not get set in the kernel. The result is that pata_ixp4xx_cf.ko does not get built and kmod-ata-ixp4xx-cf doesn't get created. The following patch resolves the problem by: - Setting ATA_SFF=y when kmod-ata-core is selected (almost all controllers depend on ATA_SFF) - Removing all references to ATA_SFF in all configs (platform and generic) - Adding "CONFIG_PATA_SCH is not set" to all generic configs - Removing "CONFIG_PATA_SCH is not set" from all platform configs Please confirm that this is the way to resolve the problem and apply. Thanks, Fabian Index: package/kernel/modules/block.mk =================================================================== --- package/kernel/modules/block.mk (revision 15993) +++ package/kernel/modules/block.mk (working copy) @@ -11,7 +11,9 @@ SUBMENU:=$(BLOCK_MENU) TITLE:=Serial and Parallel ATA support DEPENDS:=...@pci_support @LINUX_2_6 +kmod-scsi-core - KCONFIG:=CONFIG_ATA + KCONFIG:= \ + CONFIG_ATA \ + CONFIG_ATA_SFF=y FILES:=$(LINUX_DIR)/drivers/ata/libata.$(LINUX_KMOD_SUFFIX) AUTOLOAD:=$(call AutoLoad,21,libata) endef Index: target/linux/generic-2.6/config-2.6.30 =================================================================== --- target/linux/generic-2.6/config-2.6.30 (revision 15993) +++ target/linux/generic-2.6/config-2.6.30 (working copy) @@ -1418,6 +1418,7 @@ # CONFIG_PATA_RADISYS is not set # CONFIG_PATA_RZ1000 is not set # CONFIG_PATA_SC1200 is not set +# CONFIG_PATA_SCH is not set # CONFIG_PATA_SERVERWORKS is not set # CONFIG_PATA_SIL680 is not set # CONFIG_PATA_SIS is not set Index: target/linux/generic-2.6/config-2.6.21 =================================================================== --- target/linux/generic-2.6/config-2.6.21 (revision 15993) +++ target/linux/generic-2.6/config-2.6.21 (working copy) @@ -1021,6 +1021,7 @@ # CONFIG_PATA_RADISYS is not set # CONFIG_PATA_RZ1000 is not set # CONFIG_PATA_SC1200 is not set +# CONFIG_PATA_SCH is not set # CONFIG_PATA_SERVERWORKS is not set # CONFIG_PATA_SIL680 is not set # CONFIG_PATA_SIS is not set Index: target/linux/generic-2.6/config-2.6.23 =================================================================== --- target/linux/generic-2.6/config-2.6.23 (revision 15993) +++ target/linux/generic-2.6/config-2.6.23 (working copy) @@ -1107,6 +1107,7 @@ # CONFIG_PATA_RADISYS is not set # CONFIG_PATA_RZ1000 is not set # CONFIG_PATA_SC1200 is not set +# CONFIG_PATA_SCH is not set # CONFIG_PATA_SERVERWORKS is not set # CONFIG_PATA_SIL680 is not set # CONFIG_PATA_SIS is not set Index: target/linux/generic-2.6/config-2.6.25 =================================================================== --- target/linux/generic-2.6/config-2.6.25 (revision 15993) +++ target/linux/generic-2.6/config-2.6.25 (working copy) @@ -1175,6 +1175,7 @@ # CONFIG_PATA_RADISYS is not set # CONFIG_PATA_RZ1000 is not set # CONFIG_PATA_SC1200 is not set +# CONFIG_PATA_SCH is not set # CONFIG_PATA_SERVERWORKS is not set # CONFIG_PATA_SIL680 is not set # CONFIG_PATA_SIS is not set Index: target/linux/generic-2.6/config-2.6.27 =================================================================== --- target/linux/generic-2.6/config-2.6.27 (revision 15993) +++ target/linux/generic-2.6/config-2.6.27 (working copy) @@ -68,7 +68,6 @@ # CONFIG_ATALK is not set # CONFIG_ATA_OVER_ETH is not set # CONFIG_ATARI_PARTITION is not set -# CONFIG_ATA_SFF is not set # CONFIG_ATH5K is not set # CONFIG_ATH9K is not set # CONFIG_ATL1E is not set @@ -1274,6 +1273,7 @@ # CONFIG_PATA_RADISYS is not set # CONFIG_PATA_RZ1000 is not set # CONFIG_PATA_SC1200 is not set +# CONFIG_PATA_SCH is not set # CONFIG_PATA_SERVERWORKS is not set # CONFIG_PATA_SIL680 is not set # CONFIG_PATA_SIS is not set Index: target/linux/generic-2.6/config-2.6.28 =================================================================== --- target/linux/generic-2.6/config-2.6.28 (revision 15993) +++ target/linux/generic-2.6/config-2.6.28 (working copy) @@ -71,7 +71,6 @@ # CONFIG_ATALK is not set # CONFIG_ATA_OVER_ETH is not set # CONFIG_ATARI_PARTITION is not set -# CONFIG_ATA_SFF is not set # CONFIG_ATH5K is not set # CONFIG_ATH9K is not set # CONFIG_ATL1E is not set @@ -1350,6 +1349,7 @@ # CONFIG_PATA_RADISYS is not set # CONFIG_PATA_RZ1000 is not set # CONFIG_PATA_SC1200 is not set +# CONFIG_PATA_SCH is not set # CONFIG_PATA_SERVERWORKS is not set # CONFIG_PATA_SIL680 is not set # CONFIG_PATA_SIS is not set Index: target/linux/orion/config-default =================================================================== --- target/linux/orion/config-default (revision 15993) +++ target/linux/orion/config-default (working copy) @@ -15,7 +15,6 @@ CONFIG_ATA=m # CONFIG_ATA_NONSTANDARD is not set # CONFIG_ATA_PIIX is not set -CONFIG_ATA_SFF=y # CONFIG_ATM is not set # CONFIG_ATMEL is not set CONFIG_BASE_SMALL=0 @@ -184,7 +183,6 @@ # CONFIG_OUTER_CACHE is not set CONFIG_PAGEFLAGS_EXTENDED=y CONFIG_PATA_ARTOP=m -# CONFIG_PATA_SCH is not set # CONFIG_PC300 is not set CONFIG_PCI=y # CONFIG_PCI200SYN is not set Index: target/linux/kirkwood/config-default =================================================================== --- target/linux/kirkwood/config-default (revision 15993) +++ target/linux/kirkwood/config-default (working copy) @@ -14,7 +14,6 @@ CONFIG_ATA=m # CONFIG_ATA_NONSTANDARD is not set # CONFIG_ATA_PIIX is not set -CONFIG_ATA_SFF=y CONFIG_BASE_SMALL=0 CONFIG_BITREVERSE=y CONFIG_CACHE_FEROCEON_L2=y @@ -126,7 +125,6 @@ CONFIG_PAGEFLAGS_EXTENDED=y CONFIG_PAGE_OFFSET=0xC0000000 CONFIG_PATA_ARTOP=m -# CONFIG_PATA_SCH is not set CONFIG_PCI=y # CONFIG_PCI_STUB is not set CONFIG_PCI_SYSCALL=y Index: target/linux/rb532/config-2.6.28 =================================================================== --- target/linux/rb532/config-2.6.28 (revision 15993) +++ target/linux/rb532/config-2.6.28 (working copy) @@ -11,7 +11,6 @@ CONFIG_ATA=y # CONFIG_ATA_NONSTANDARD is not set # CONFIG_ATA_PIIX is not set -CONFIG_ATA_SFF=y CONFIG_BASE_SMALL=0 # CONFIG_BCM47XX is not set CONFIG_BITREVERSE=y @@ -127,7 +126,6 @@ # CONFIG_NXP_STB225 is not set CONFIG_PAGEFLAGS_EXTENDED=y CONFIG_PATA_RB532=y -# CONFIG_PATA_SCH is not set CONFIG_PCI=y CONFIG_PCI_DOMAINS=y CONFIG_PCSPKR_PLATFORM=y Index: target/linux/ixp4xx/config-default =================================================================== --- target/linux/ixp4xx/config-default (revision 15993) +++ target/linux/ixp4xx/config-default (working copy) @@ -21,7 +21,6 @@ CONFIG_ATA=m # CONFIG_ATA_NONSTANDARD is not set # CONFIG_ATA_PIIX is not set -CONFIG_ATA_SFF=y # CONFIG_ATM is not set # CONFIG_ATMEL is not set CONFIG_BASE_SMALL=0 @@ -200,7 +199,6 @@ CONFIG_PAGEFLAGS_EXTENDED=y CONFIG_PATA_ARTOP=m CONFIG_PATA_IXP4XX_CF=m -# CONFIG_PATA_SCH is not set # CONFIG_PC300 is not set CONFIG_PCI=y # CONFIG_PCI200SYN is not set Index: target/linux/ixp4xx/config-2.6.27 =================================================================== --- target/linux/ixp4xx/config-2.6.27 (revision 15993) +++ target/linux/ixp4xx/config-2.6.27 (working copy) @@ -23,7 +23,6 @@ # CONFIG_ATA is not set # CONFIG_ATA_NONSTANDARD is not set # CONFIG_ATA_PIIX is not set -CONFIG_ATA_SFF=y # CONFIG_ATM is not set # CONFIG_ATMEL is not set CONFIG_BASE_SMALL=0 @@ -171,7 +170,6 @@ CONFIG_PAGEFLAGS_EXTENDED=y # CONFIG_PATA_ARTOP is not set # CONFIG_PATA_IXP4XX_CF is not set -# CONFIG_PATA_SCH is not set CONFIG_PCI=y CONFIG_PCI_SYSCALL=y # CONFIG_R6040 is not set Index: target/linux/ixp4xx/config-2.6.28 =================================================================== --- target/linux/ixp4xx/config-2.6.28 (revision 15993) +++ target/linux/ixp4xx/config-2.6.28 (working copy) @@ -23,7 +23,6 @@ # CONFIG_ATA is not set # CONFIG_ATA_NONSTANDARD is not set # CONFIG_ATA_PIIX is not set -CONFIG_ATA_SFF=y # CONFIG_ATM is not set # CONFIG_ATMEL is not set CONFIG_BASE_SMALL=0 @@ -174,7 +173,6 @@ CONFIG_PAGEFLAGS_EXTENDED=y # CONFIG_PATA_ARTOP is not set # CONFIG_PATA_IXP4XX_CF is not set -# CONFIG_PATA_SCH is not set CONFIG_PCI=y CONFIG_PCI_SYSCALL=y # CONFIG_R6040 is not set Index: target/linux/cobalt/config-default =================================================================== --- target/linux/cobalt/config-default (revision 15993) +++ target/linux/cobalt/config-default (working copy) @@ -10,7 +10,6 @@ CONFIG_ATA=y # CONFIG_ATA_NONSTANDARD is not set # CONFIG_ATA_PIIX is not set -CONFIG_ATA_SFF=y CONFIG_BASE_SMALL=0 # CONFIG_BCM47XX is not set CONFIG_BINFMT_ELF32=y @@ -294,7 +293,6 @@ # CONFIG_PACKET_MMAP is not set CONFIG_PAGEFLAGS_EXTENDED=y # CONFIG_PARTITION_ADVANCED is not set -# CONFIG_PATA_SCH is not set CONFIG_PATA_VIA=y CONFIG_PCI=y CONFIG_PCI_DOMAINS=y Index: target/linux/adm5120/router_le/config-2.6.28 =================================================================== --- target/linux/adm5120/router_le/config-2.6.28 (revision 15993) +++ target/linux/adm5120/router_le/config-2.6.28 (working copy) @@ -42,7 +42,6 @@ CONFIG_ATA=m # CONFIG_ATA_NONSTANDARD is not set # CONFIG_ATA_PIIX is not set -CONFIG_ATA_SFF=y CONFIG_BASE_SMALL=0 # CONFIG_BCM47XX is not set CONFIG_BITREVERSE=y Index: target/linux/adm5120/router_le/config-2.6.30 =================================================================== --- target/linux/adm5120/router_le/config-2.6.30 (revision 15993) +++ target/linux/adm5120/router_le/config-2.6.30 (working copy) @@ -41,7 +41,6 @@ CONFIG_ATA=m # CONFIG_ATA_NONSTANDARD is not set # CONFIG_ATA_PIIX is not set -CONFIG_ATA_SFF=y CONFIG_BASE_SMALL=0 # CONFIG_BCM47XX is not set # CONFIG_BINARY_PRINTF is not set @@ -186,7 +185,6 @@ CONFIG_PAGEFLAGS_EXTENDED=y # CONFIG_PARTITION_ADVANCED is not set CONFIG_PATA_RB153_CF=m -# CONFIG_PATA_SCH is not set CONFIG_PCI=y CONFIG_PCI_DISABLE_COMMON_QUIRKS=y CONFIG_PCI_DOMAINS=y _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
