Hello gang,

I noticed that when adding 'option ignore 1' to an interface in 
/etc/config/dhcp, the interface is indeed added to the dnsmasq command line as 
a -2 param, which is correct, but the --dhcp-range also get appended to the 
command line, which causes dnsmasq to fail.  If no range is provided for the 
interface in /etc/conf/dhcp, the --dhcp-range is added anyway for that 
interface using the values from the previous dhcp-enabled interface.

Basically, if ignore is set to 1, it should not go through the range 
configuration part of the script.  Here's a simple patch to solve the problem.  
I am not entirely privy to the script so there might be something I'm missing 
Maybe we shouldn't return 0 right away for reasons I'm not aware of in some 
special cases.  If so, be sure to point them out and ignore my nonsense.

Singed-off-by: FinboySlick <jonat...@navigue.com>

Index: package/dnsmasq/files/dnsmasq.init
===================================================================
--- package/dnsmasq/files/dnsmasq.init  (revision 15606)
+++ package/dnsmasq/files/dnsmasq.init  (working copy)
@@ -216,7 +216,7 @@
                DNS_SERVERS="$DNS_SERVERS $dnsserver"
        }
 
-       append_bool "$cfg" ignore "-2 $ifname"
+       append_bool "$cfg" ignore "-2 $ifname" && return 0
 
        config_get proto "$net" proto
        [ static = "$proto" ] || return 0

_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to