Yuji Mano wrote: > Yuji Mano wrote: >> Yuji Mano wrote: >>> Hi. >>> >>> I checkout from the git repository but noticed it doesn't pull down empty >>> directories (trunk/package/base-files/files/etc/uci-defaults). >>> This wasn't a problem for me until I set CONFIG_UCI_PRECONFIG. >>> The build expects the '/etc/uci-defaults' to exist in the root fs and >>> otherwise causes errors: >>> >>> make[3]: Entering directory `/home/ymano/openwrt/trunk' >>> ( \ >>> echo "uci set 'network.lan.dns='"; \ >>> echo "uci set 'network.lan.proto=dhcp'"; \ >>> echo "uci set 'network.lan.gateway='"; \ >>> echo "uci set 'network.lan.netmask=255.255.255.0'"; \ >>> echo "uci set 'network.lan.ipaddr=192.168.1.1'"; \ >>> \ >>> ) > >>> /home/ymano/openwrt/trunk/build_dir/powerpc/root-ps3/etc/uci-defaults/base-files >>> --: line 7: >>> /home/ymano/openwrt/trunk/build_dir/powerpc/root-ps3/etc/uci-defaults/base-files: >>> No such file or directory >>> make[3]: *** >>> [/home/ymano/openwrt/trunk/build_dir/powerpc/root-ps3/etc/uci-defaults/base-files] >>> Error 1 >>> make[3]: Leaving directory `/home/ymano/openwrt/trunk' >>> make[2]: [package/rootfs-prepare] Error 2 (ignored) >>> >>> The build otherwise continues on without really letting me know that >>> something has gone horribly wrong, leaving me confused during runtime why >>> my proto is set to 'static' even though I swore I set it to 'dhcp'... >>> should the build stop on such an error? >>> >>> Can we either add dummy files to empty directories in the repository so git >>> will properly pull them down? >>> Or can we make sure the build creates necessary directories? >> >> Bumping my previous post. >> Am I the only one using git and having this problem? >> >> Can we at least fix package uci to create the necessary directory at build >> time? > > The more I think about it the more I think it makes no sense to have the > empty directory (trunk/package/base-files/files/etc/uci-defaults). > Package uci should create the directory during package install unless there > is some other package that depends on it, > in which case that package should create the directory as well during install. > > The patch below fixes the package uci build. > Also 'trunk/package/base-files/files/etc/uci-defaults/' should be removed > from the repository. > > Regards, > Yuji > > --- > package/uci/Makefile | 1 + > 1 file changed, 1 insertion(+) > > --- a/package/uci/Makefile > +++ b/package/uci/Makefile > @@ -78,6 +78,7 @@ define Package/libuci-lua/install > endef > > define Package/uci/install > + $(INSTALL_DIR) $(1)/etc/uci-defaults > $(INSTALL_DIR) $(1)/sbin > $(INSTALL_BIN) $(PKG_BUILD_DIR)/uci $(1)/sbin/ > $(CP) ./files/uci/* $(1)/
Still no comments regarding this patch... Can somebody comment or commit the patch? - Yuji _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org http://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
