> Ok, I looked at the diag code and I think this simply isn't going to work. > That gpiomask is a global mask that everybody can override. > In the end, I think diag needs a rewrite on 2.6 to use led-triggers and > stuff, properly. > > In any case, the gpiomask does not belong into the mmc_over_gpio config > file. > It belongs into a diag config file. > We can not correctly set it from within the mmc_over_gpio config. For > example, > what if another application or driver also wants to set the mask? So it > will > end up overriding it (or we override its settings). Read/set/write of the > proc > file is also not an option, as that's racy and doesn't work very well in > a shell script. > > So this gpiomask really belongs into a seperate diag-specific config file.
Ok. Putting the gpiomask into a diag config file seems the best solution for the moment. I'll create a new diff. _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org http://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
