Attention is currently required from: MaxF, syzzer.

plaisthos has posted comments on this change by MaxF. ( 
http://gerrit.openvpn.net/c/openvpn/+/1441?usp=email )

Change subject: Add support for Mbed TLS 4
......................................................................


Patch Set 5:

(1 comment)

File src/openvpn/ssl_mbedtls.c:

http://gerrit.openvpn.net/c/openvpn/+/1441/comment/46ea0c7e_a2445a5e?usp=email :
PS5, Line 610: {
/Users/arne/oss/openvpn-git/src/openvpn/ssl_mbedtls.c:609:1: error: unused 
function 'external_pkcs1_sign' [-Werror,-Wunused-function]
  609 | external_pkcs1_sign(void *ctx_voidptr, int (*f_rng)(void *, unsigned 
char *, size_t), void *p_rng,

  And I do not see this function being used anywhere. Please double check this 
with Werror.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1441?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ib251d546d993b96ed3bd8cb9111bcc627cdb0fae
Gerrit-Change-Number: 1441
Gerrit-PatchSet: 5
Gerrit-Owner: MaxF <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-CC: syzzer <[email protected]>
Gerrit-Attention: syzzer <[email protected]>
Gerrit-Attention: MaxF <[email protected]>
Gerrit-Comment-Date: Wed, 21 Jan 2026 13:04:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to