Additional unit tests are good, especially when we have no real test
coverage for this important data structure yet.
The approach of having memory-intensive tests be disabled by default
(and be disabled by the standard unix build) is also useful - smaller
systems would have spurious failures that scare people, with little
gain.
I had some reservations about the ASSERT()s being added - but I have
come to the conclusion that they are fine. One is needed to test the
maximum allocation size, and the other one can never fire in the
current source (because both callers pass in a pointer to a local
variable).
A quick local (autoconf) test passes, BB is also all green.
Your patch has been applied to the master branch.
commit 75cc34eccca990a2efbaa02639311def6b2cd70f
Author: Frank Lichtenheld
Date: Fri Dec 12 13:03:46 2025 +0100
mbuf: Add unit tests
Signed-off-by: Frank Lichtenheld <[email protected]>
Acked-by: Gert Doering <[email protected]>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1432
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg35050.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
