Attention is currently required from: cron2, flichtenheld.

plaisthos has posted comments on this change by plaisthos. ( 
http://gerrit.openvpn.net/c/openvpn/+/1435?usp=email )

Change subject: Allow test-crypto to work without the --secret argument
......................................................................


Patch Set 4:

(1 comment)

File src/openvpn/init.c:

http://gerrit.openvpn.net/c/openvpn/+/1435/comment/133004d8_d3bfcd06?usp=email :
PS3, Line 3528:     else if (c->options.test_crypto)
> Why not do this test first and remove all handling of test-crypto from 
> do_init_crypto_static?
So basically to currently still support the old mode that allows to use 
--secret to manually specify the key. When we remove --secret in OpenVPN 2.8 
master brnach it is going away entirely anyway.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1435?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I72947bd4f0213fd118327f740daeb1d86ae166de
Gerrit-Change-Number: 1435
Gerrit-PatchSet: 4
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: cron2 <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: cron2 <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Thu, 11 Dec 2025 14:44:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to