Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1430?usp=email
to review the following change.
Change subject: tun.c: set IPv4 address temporary on Windows
......................................................................
tun.c: set IPv4 address temporary on Windows
Use store=active to set IPv4 address temporary so that
it will be removed on reboot. This makes the behavior
consistent with deletion and IPv6, where we already use
store=active.
https://learn.microsoft.com/en-us/windows-server/administration/windows-commands/netsh-interface
GitHub: https://github.com/OpenVPN/openvpn/issues/915
Change-Id: I07311f397e6cd278b90c33f024e927c282cd03e4
Signed-off-by: Lev Stipakov <[email protected]>
---
M src/openvpn/tun.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/30/1430/1
diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c
index 0299285..849eddc 100644
--- a/src/openvpn/tun.c
+++ b/src/openvpn/tun.c
@@ -5119,8 +5119,8 @@
}
else
{
- /* example: netsh interface ip set address 42 static 10.3.0.1
255.255.255.0 */
- argv_printf(&argv, "%s%s interface ip set address %lu static %s
%s", get_win_sys_path(),
+ /* example: netsh interface ip set address 42 static 10.3.0.1
255.255.255.0 store=active */
+ argv_printf(&argv, "%s%s interface ip set address %lu static %s %s
store=active", get_win_sys_path(),
NETSH_PATH_SUFFIX, adapter_index, print_in_addr_t(ip,
0, &gc),
print_in_addr_t(netmask, 0, &gc));
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1430?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I07311f397e6cd278b90c33f024e927c282cd03e4
Gerrit-Change-Number: 1430
Gerrit-PatchSet: 1
Gerrit-Owner: stipa <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
