Attention is currently required from: its_Giaan, plaisthos.

flichtenheld has posted comments on this change by its_Giaan. ( 
http://gerrit.openvpn.net/c/openvpn/+/1425?usp=email )

Change subject: Deprecate --fast-io option
......................................................................


Patch Set 3: Code-Review-1

(3 comments)

File doc/man-sections/unsupported-options.rst:

http://gerrit.openvpn.net/c/openvpn/+/1425/comment/e0878cd5_9c32f4ab?usp=email :
PS3, Line 53: --fast-io
The options are alphabetically sorted. Please put it in the right spot.


http://gerrit.openvpn.net/c/openvpn/+/1425/comment/d3d06463_5f63df3e?usp=email :
PS3, Line 54:   Ignored since OpenVPN 2.7. This option became broken with 
latest changes
"latest" feels wrong in this context. How about "This option became broken due 
to changes to the event loop."?


File src/openvpn/options.c:

http://gerrit.openvpn.net/c/openvpn/+/1425/comment/4514d830_40647eb5?usp=email :
PS3, Line 6600:         msg(M_WARN, "DEPRECATED OPTION: --fast-io option 
ignored. ");
Remove superfluous space at the end of the line.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1425?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I2c0a0b55ad56e704d4bd19f1fbc1c30c83fae14c
Gerrit-Change-Number: 1425
Gerrit-PatchSet: 3
Gerrit-Owner: its_Giaan <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: its_Giaan <[email protected]>
Gerrit-Comment-Date: Tue, 09 Dec 2025 13:51:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to