Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1378?usp=email )
Change subject: tun: Refactor BSD write_tun/read_tun ...................................................................... Patch Set 5: Code-Review-1 Copied votes on follow-up patch sets have been updated: * Code-Review-1 has been copied to patch set 6 (copy condition: "changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN"). (3 comments) Patchset: PS5: I think this is a good change and BB confirms that it works (or worked, a few weeks ago). I think the comments could be improved a bit more... File src/openvpn/tun.c: http://gerrit.openvpn.net/c/openvpn/+/1378/comment/9197213b_fa155467?usp=email : PS5, Line 1705: * go away for TAP devices. I think this should be reworded ("we *have* tested") to be something like ``` * For TAP devices, no extra header is needed, so we need to check for DEV_TYPE_TUN ``` or so? Or maybe even shorter "For TAP devices, this is not needed and must not be done" or so (so it's clear "even if we wanted to keep the code the same, we can't"). http://gerrit.openvpn.net/c/openvpn/+/1378/comment/0f65128b_1360ae44?usp=email : PS5, Line 1785: #if !defined(TARGET_DARWIN) I think this also warrants a comment ``` /* MacOS is slightly different again (extra variant for UTUN) so this platform * has its own read_tun()/write_tun() with the necessary conditionals below */ ``` (it took me a while to remember and find the specifics, someone else will be even more confused) -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1378?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ifd9384287648d1f37a625d9ed6a09733208fa56c Gerrit-Change-Number: 1378 Gerrit-PatchSet: 5 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Tue, 09 Dec 2025 10:49:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
