Makes sense, thanks Gert, I've been trying to track, when I can, some of the work going into the 2.7 release, I understand you folks have priorities in place already, I don't want to interrupt or delay you all :) I'm not an expert yet on all the different code paths, esp. when it comes to the push and pull options and edge cases involved. I didn't know about that client side full tun restart procedure but if you have any links about it I'd be interested to try and read through the code - otherwise I can try to search for it if I can find some relevant keywords to look for :)
Thanks again as always, Jon C On Wed, Nov 19, 2025 at 10:12 AM Gert Doering <[email protected]> wrote: > Hi, > > On Wed, Nov 19, 2025 at 09:54:30AM -0500, Jon Chiappetta wrote: > > Yes, that is correct, it does impact the multi-threaded operation, > however, > > the older logic has a strcmp between the old IP and the new IP before > > performing the learn and unlearn logic in the update_vhash function which > > is what SHOULD happen, this is important and correct. Why would you want > to > > waste cycles and operations doing that when the IPs haven't even changed > or > > differed in value? It doesn't make any logical sense either way even in > > single threaded operation... > > The operational model underlying here is "you send an update when you > want to change something", so spending brain & code on "verify that there > is an actual change, and skip the update if not" is not effort well spent > (also, the client does a full tun restart, which takes much longer than > the server side - this is what would need optimizing first ;-) ). > > The code, as it is now, is nice and compact, easy to read, and does what > is supposed to do. > > We can come back to this in the "after 2.7.0 release" timeframe when > we open the tree for "refactor and improve code style and details" changes > again - right now, we need to focus on actual bugfixes. > > gert > > -- > "If was one thing all people took for granted, was conviction that if you > feed honest figures into a computer, honest figures come out. Never > doubted > it myself till I met a computer with a sense of humor." > Robert A. Heinlein, The Moon is a Harsh > Mistress > > Gert Doering - Munich, Germany > [email protected] >
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
