Attention is currently required from: plaisthos. cron2 has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1369?usp=email )
The change is no longer submittable: Code-Review is unsatisfied now. Change subject: Fix dco with null cipher being enabled without auth none ...................................................................... Patch Set 1: Code-Review-2 (2 comments) Patchset: PS1: this is missing the required "return false" + gc cleanup File src/openvpn/dco.c: http://gerrit.openvpn.net/c/openvpn/+/1369/comment/bb353f92_d38bfc69?usp=email : PS1, Line 486: } should this have a `gc_free(&gc); return false;` here? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1369?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I1104044701145fa37cea857e2e0e0fcac7a2bee3 Gerrit-Change-Number: 1369 Gerrit-PatchSet: 1 Gerrit-Owner: plaisthos <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Comment-Date: Wed, 19 Nov 2025 13:47:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
