Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1302?usp=email )
Change subject: ssl: Clean up type handling in parse_early_negotiation_tlvs() ...................................................................... Patch Set 6: Code-Review-1 (1 comment) Patchset: PS6: I don't like this one. Looking at `buf_read_u16()`, this is really an unsigned type, so parsing this as int and checking for `len < 0` is just wrong. Since there are not very many callers, I would tend to actually make it return a proper `uint16_t` - which is what `ntohs(ret)` produces anyway - and fix those callers that need to be able to deal with negative values (if any). -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1302?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie7ad637223c332f7611c09b20a8d7a3a92d97ec7 Gerrit-Change-Number: 1302 Gerrit-PatchSet: 6 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Sun, 16 Nov 2025 18:53:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
