Attention is currently required from: chesain, flichtenheld, plaisthos, uddr.
Hello flichtenheld, plaisthos, uddr,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1338?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review-1 by uddr
Change subject: CONTRIBUTING: add Gerrit option + links
......................................................................
CONTRIBUTING: add Gerrit option + links
- Add Gerrit as an alternative review path
- Add links: signup, web UI, best practices
- Final patches still go to openvpn-devel
Change-Id: Ifb4e9d79c167337fb780b53141d080abf55f3f5e
Signed-off-by: chesain <[email protected]>
Refs: openvpn/openvpn#845
Link: https://github.com/OpenVPN/openvpn/issues/845
---
M CONTRIBUTING.rst
1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/38/1338/2
diff --git a/CONTRIBUTING.rst b/CONTRIBUTING.rst
index 67baa4e..e7afeafe 100644
--- a/CONTRIBUTING.rst
+++ b/CONTRIBUTING.rst
@@ -8,6 +8,13 @@
- https://lists.sourceforge.net/lists/listinfo/openvpn-devel
+Alternatively, you can use Gerrit for code review:
+
+- Web UI: https://gerrit.openvpn.net/
+- Best practices & account setup:
https://community.openvpn.net/Development/GerritBestPractices
+
+Note: final, approved patches are still sent to the mailing list.
+
While we do not merge GitHub pull requests as-is, we do allow their use for
code
review purposes. After the patch has been ACKed (reviewed and accepted), it
must
be sent to the mailing list. This last step does not necessarily need to be
done
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1338?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: release/2.6
Gerrit-Change-Id: Ifb4e9d79c167337fb780b53141d080abf55f3f5e
Gerrit-Change-Number: 1338
Gerrit-PatchSet: 2
Gerrit-Owner: chesain <[email protected]>
Gerrit-Reviewer: chesain <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-Reviewer: uddr <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Attention: uddr <[email protected]>
Gerrit-Attention: chesain <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
