Attention is currently required from: cron2, d12fk, flichtenheld, plaisthos.
selvanair has posted comments on this change by d12fk. ( http://gerrit.openvpn.net/c/openvpn/+/1307?usp=email ) Change subject: iservice: validate config path better ...................................................................... Patch Set 3: (2 comments) File src/openvpnserv/validate.c: http://gerrit.openvpn.net/c/openvpn/+/1307/comment/68d02a1c_0271f54d?usp=email : PS3, Line 88: HRESULT res = PathCchCanonicalizeEx(config_dir, _countof(config_dir), s->config_dir, As you are effectively reverting commit 05a8ba808, also remove "HAVE_PATHCCH_ENSURE_TRAILING_SLASH" introduced by there and related changes in CMakeFiles.txt. Also the follow up commit d5e6b72460a. http://gerrit.openvpn.net/c/openvpn/+/1307/comment/1a4c657c_0c6a5d1e?usp=email : PS3, Line 85: return res == S_OK && wcsncmp(config_path, s->config_dir, wcslen(s->config_dir)) == 0; While at it, make this case insensitve. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1307?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I0e94068f467f2899daf133b032a785d2d7fc05e4 Gerrit-Change-Number: 1307 Gerrit-PatchSet: 3 Gerrit-Owner: d12fk <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-CC: selvanair <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: cron2 <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Attention: d12fk <[email protected]> Gerrit-Comment-Date: Thu, 06 Nov 2025 20:30:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
