Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1343?usp=email
to review the following change.
Change subject: openvpnserv: Disallow stdin as config unless user is authorized
......................................................................
openvpnserv: Disallow stdin as config unless user is authorized
Reported by: <[email protected]>
Change-Id: I356faeebfade1eed9b40d6700b13621c357ec5ac
Signed-off-by: Selva Nair <[email protected]>
---
M src/openvpnserv/validate.c
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/43/1343/1
diff --git a/src/openvpnserv/validate.c b/src/openvpnserv/validate.c
index 2187fb5..ddaa381 100644
--- a/src/openvpnserv/validate.c
+++ b/src/openvpnserv/validate.c
@@ -68,6 +68,11 @@
const WCHAR *config_file = NULL;
WCHAR config_dir[MAX_PATH];
+ /* fname = stdin is special: do not treat it as a relative path */
+ if (wcscmp(fname, L"stdin") == 0)
+ {
+ return FALSE;
+ }
/* convert fname to full path */
if (PathIsRelativeW(fname))
{
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1343?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I356faeebfade1eed9b40d6700b13621c357ec5ac
Gerrit-Change-Number: 1343
Gerrit-PatchSet: 1
Gerrit-Owner: selvanair <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
