Not sure if MultiByteToWideChar() could ever fail here (UTF8 decoding
errors are only reported if MB_ERR_INVALID_CHARS is passed in), but
then, checking for an error here will ensure that we can't crash
further down. So, good practice.
I have verified that all callers of utf8to16_size() and utf8to16()
can handle NULL returns fine, so this is safe.
Your patch has been applied to the master and release/2.6 branch
(bugfix, with some shoehorning).
commit fdd4072541ba52e297c19672d3b1e7021d14bc91 (master)
commit 5b5fdb05d969abc0be7a701c752821299cb98d5e (release/2.6)
Author: Heiko Hund
Date: Thu Oct 30 20:47:31 2025 +0100
iservice: check return value of MultiByteToWideChar
Signed-off-by: Heiko Hund <[email protected]>
Acked-by: Gert Doering <[email protected]>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1306
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg34071.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
