Checked each individual location.  I don't think any of these can
reasonably ever overflow - but if we do have checks, we must ensure that
the check is meaningful.  So this is a good fix.

BB also confirms "does not break anything" ;-)

(Not applied to 2.6, as many snprintf() calls looks quite different there)

Your patch has been applied to the master branch.

commit d7f86ddaf403aafa4a6098d02d76910a821b038e
Author: Arne Schwabe
Date:   Thu Oct 30 20:36:30 2025 +0100

     Ensure return value of snprintf is correctly checked

     Signed-off-by: Arne Schwabe <[email protected]>
     Acked-by: Gert Doering <[email protected]>
     Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1330
     Message-Id: <[email protected]>
     URL: 
https://www.mail-archive.com/[email protected]/msg34063.html
     Signed-off-by: Gert Doering <[email protected]>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to