cron2 has uploaded a new patch set (#2) to the change originally created by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1328?usp=email )
The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: Fix warnings about conversion from int to unsigned char/uint8_t ...................................................................... Fix warnings about conversion from int to unsigned char/uint8_t When compiling with cmake -DCMAKE_BUILD_TYPE=ASAN under Ubuntu 25.10 (gcc 15.2.0). Explicitly cast these instances to uint8_t/unssigned char to silence this warning. Change-Id: I648ee99b1152b1248d1b3e64af7679ab99f1388f Signed-off-by: Arne Schwabe <[email protected]> Acked-by: Gert Doering <[email protected]> Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1328 Message-Id: <[email protected]> URL: https://www.mail-archive.com/[email protected]/msg34065.html Signed-off-by: Gert Doering <[email protected]> --- M src/openvpn/httpdigest.c M src/openvpn/mroute.c 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/28/1328/2 diff --git a/src/openvpn/httpdigest.c b/src/openvpn/httpdigest.c index be20638..3e6520a 100644 --- a/src/openvpn/httpdigest.c +++ b/src/openvpn/httpdigest.c @@ -46,7 +46,7 @@ } else { - Hex[i * 2] = (j + 'a' - 10); + Hex[i * 2] = (unsigned char)(j + 'a' - 10); } j = Bin[i] & 0xf; if (j <= 9) @@ -55,7 +55,7 @@ } else { - Hex[i * 2 + 1] = (j + 'a' - 10); + Hex[i * 2 + 1] = (unsigned char)(j + 'a' - 10); } } Hex[HASHHEXLEN] = '\0'; diff --git a/src/openvpn/mroute.c b/src/openvpn/mroute.c index b50d48f..d17902f 100644 --- a/src/openvpn/mroute.c +++ b/src/openvpn/mroute.c @@ -337,7 +337,7 @@ } else { - ma->v6.addr.s6_addr[byte--] &= (0xFF << bits_to_clear); + ma->v6.addr.s6_addr[byte--] &= (uint8_t)(0xFF << bits_to_clear); bits_to_clear = 0; } } -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1328?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I648ee99b1152b1248d1b3e64af7679ab99f1388f Gerrit-Change-Number: 1328 Gerrit-PatchSet: 2 Gerrit-Owner: plaisthos <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-CC: openvpn-devel <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
