cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1327?usp=email )
Change subject: fix key_state_gen_auth_control_files probably checking file creation ...................................................................... fix key_state_gen_auth_control_files probably checking file creation When the auth_failed_reason_file was added, it was forgotten to also add it to the conditions that determine if the file creation was successful. Reported-by: Joshua Rogers <[email protected]> Found-by: ZeroPath (https://zeropath.com/) Change-Id: I94d2bdd234a1c416b78924d044bf7e57f1bed8c4 Signed-off-by: Arne Schwabe <[email protected]> Acked-by: Gert Doering <[email protected]> Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1327 Message-Id: <[email protected]> URL: https://www.mail-archive.com/[email protected]/msg34067.html Signed-off-by: Gert Doering <[email protected]> --- M src/openvpn/ssl_verify.c 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/openvpn/ssl_verify.c b/src/openvpn/ssl_verify.c index 993d22c..a16f5fa 100644 --- a/src/openvpn/ssl_verify.c +++ b/src/openvpn/ssl_verify.c @@ -992,7 +992,7 @@ const char *apf = platform_create_temp_file(opt->tmp_dir, "apf", &gc); const char *afr = platform_create_temp_file(opt->tmp_dir, "afr", &gc); - if (acf && apf) + if (acf && apf && afr) { ads->auth_control_file = string_alloc(acf, NULL); ads->auth_pending_file = string_alloc(apf, NULL); @@ -1004,7 +1004,7 @@ } gc_free(&gc); - return (acf && apf); + return (acf && apf && afr); } /** -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1327?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I94d2bdd234a1c416b78924d044bf7e57f1bed8c4 Gerrit-Change-Number: 1327 Gerrit-PatchSet: 2 Gerrit-Owner: plaisthos <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-CC: openvpn-devel <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
