Attention is currently required from: mrbff, plaisthos.

flichtenheld has posted comments on this change by mrbff. ( 
http://gerrit.openvpn.net/c/openvpn/+/1316?usp=email )

Change subject: PUSH_UPDATE server: added new unit tests and improved 
documentation
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

File tests/unit_tests/openvpn/test_push_update_msg.c:

http://gerrit.openvpn.net/c/openvpn/+/1316/comment/c3c8a28a_a6ce6843?usp=email :
PS1, Line 147:                 printf("\n\nexpected_size: %lu\n  actual_size: 
%lu", res_len, str_len);
```suggestion
                printf("\n\nexpected_size: %zu\n  actual_size: %zu", res_len, 
str_len);
```



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1316?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Idba419681fe3ccc4e6e2f6ce7592332dcff62cd9
Gerrit-Change-Number: 1316
Gerrit-PatchSet: 1
Gerrit-Owner: mrbff <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: mrbff <[email protected]>
Gerrit-Comment-Date: Tue, 28 Oct 2025 10:39:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to