Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1320?usp=email
to review the following change.
Change subject: Add ASSERT to afunix code that dev_node is always the way we
expect
......................................................................
Add ASSERT to afunix code that dev_node is always the way we expect
The calling code only calls tun_afunix_exec_child if is_tun_afunix
which checks that the path is having unix: as prefix.
But since adding an ASSERT here to ensure that it is really the case
does not cost us anything, just add the ASSERT.
Reported-By: [email protected]
Found-By: Zeropath
Change-Id: Idbb7bf279eb467fc1d56ab75a50b5eb2c8d0a57e
---
M src/openvpn/tun_afunix.c
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/20/1320/1
diff --git a/src/openvpn/tun_afunix.c b/src/openvpn/tun_afunix.c
index 4d48a31..e6f2be1 100644
--- a/src/openvpn/tun_afunix.c
+++ b/src/openvpn/tun_afunix.c
@@ -53,6 +53,8 @@
const char *msgprefix = "ERROR: failure executing process for tun:";
struct argv argv = argv_new();
+ /* we should always called with a proper unix: dev node string */
+ ASSERT(dev_node && strncmp(dev_node, "unix:", strlen("unix:")) == 0);
/* since we know that dev-node starts with unix: we can just skip that
* to get the program name */
const char *program = dev_node + strlen("unix:");
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1320?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Idbb7bf279eb467fc1d56ab75a50b5eb2c8d0a57e
Gerrit-Change-Number: 1320
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
