Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1319?usp=email
to review the following change.
Change subject: Avoid possible race condition that kill OpenVPN itself
......................................................................
Avoid possible race condition that kill OpenVPN itself
If for whatever reason the child pid is zero, we would kill ourselves
since killing 0 means killing the own process group.
Reported-By: [email protected]
Found-By: Zeropath
Change-Id: I7b94de92723f9528b01cb932bb079eedf0f1f272
---
M src/openvpn/tun_afunix.c
1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/19/1319/1
diff --git a/src/openvpn/tun_afunix.c b/src/openvpn/tun_afunix.c
index 4d48a31..124db6d 100644
--- a/src/openvpn/tun_afunix.c
+++ b/src/openvpn/tun_afunix.c
@@ -128,7 +128,12 @@
close(tt->fd);
tt->fd = 0;
}
- kill(tt->afunix.childprocess, SIGINT);
+ /* only kill the child process if the PID is not 0 to avoid killing
+ * ourselves by accident */
+ if (tt->afunix.childprocess)
+ {
+ kill(tt->afunix.childprocess, SIGINT);
+ }
free(tt->actual_name);
free(tt);
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1319?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I7b94de92723f9528b01cb932bb079eedf0f1f272
Gerrit-Change-Number: 1319
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
