Attention is currently required from: flichtenheld, ordex, plaisthos. mrbff has posted comments on this change by mrbff. ( http://gerrit.openvpn.net/c/openvpn/+/721?usp=email )
Change subject: route: extended logic to omit gateway when unnecessary ...................................................................... Patch Set 12: (6 comments) File src/openvpn/route.h: http://gerrit.openvpn.net/c/openvpn/+/721/comment/0a1b545d_f913bbc8?usp=email : PS11, Line 274: bool add_route_ipv6(struct route_ipv6 *r, const struct tuntap *tt, unsigned int flags, const struct env_set *es, openvpn_net_ctx_t *ctx, const bool is_multipoint); > The naming here and the usage seem to disagree. […] Done File src/openvpn/route.c: http://gerrit.openvpn.net/c/openvpn/+/721/comment/aaa6380b_66ab5947?usp=email : PS11, Line 1811: /* FIXME -- add on-link support for Dragonfly */ > Has this been really tested on DragonFly BSD? i tested on the first patch but i tested again the #12 on 6.4.2 and found also a bug with the ifconfig, i fixed just moving from #if defined(TARGET_FREEBSD) || defined (TARGET_DRAGONFLY) code to #if defined(TARGET_NETBSD) || defined (TARGET_DRAGONFLY) code in do_ifconfig_ipv4(). Here the logs: master: 2025-10-20 13:36:42 PUSH: Received control message: 'PUSH_REPLY,route-gateway 10.23.100.1,topology subnet,ping 5,ping-restart 30,ifconfig 10.23.100.2 255.255.255.0,peer-id 0,cipher AES-256-GCM,protocol-flags cc-exit tls-ekm dyn-tls-crypt,tun-mtu 1500' 2025-10-20 13:36:42 OPTIONS IMPORT: --ifconfig/up options modified 2025-10-20 13:36:42 OPTIONS IMPORT: route-related options modified 2025-10-20 13:36:42 OPTIONS IMPORT: tun-mtu set to 1500 2025-10-20 13:36:42 TUN/TAP device tun0 exists previously, keep at program end 2025-10-20 13:36:42 TUN/TAP device /dev/tun0 opened 2025-10-20 13:36:42 tun/tap device [tun0] opened 2025-10-20 13:36:42 /sbin/ifconfig tun0 10.23.100.2/24 mtu 1500 up ifconfig: ioctl (SIOCAIFADDR): Destination address required 2025-10-20 13:36:42 FreeBSD ifconfig failed: external program exited with error status: 1 2025-10-20 13:36:42 Exiting due to fatal error patchset #12: 2025-10-20 13:43:42 PUSH: Received control message: 'PUSH_REPLY,route-gateway 10.23.100.1,topology subnet,ping 5,ping-restart 30,ifconfig 10.23.100.2 255.255.255.0,peer-id 0,cipher AES-256-GCM,protocol-flags cc-exit tls-ekm dyn-tls-crypt,tun-mtu 1500' 2025-10-20 13:43:42 OPTIONS IMPORT: --ifconfig/up options modified 2025-10-20 13:43:42 OPTIONS IMPORT: route-related options modified 2025-10-20 13:43:42 OPTIONS IMPORT: tun-mtu set to 1500 2025-10-20 13:43:42 TUN/TAP device tun0 exists previously, keep at program end 2025-10-20 13:43:42 TUN/TAP device /dev/tun0 opened 2025-10-20 13:43:42 tun/tap device [tun0] opened 2025-10-20 13:43:42 /sbin/ifconfig tun0 10.23.100.2 10.23.100.1 mtu 1500 netmask 255.255.255.0 up 2025-10-20 13:43:42 /sbin/route add -net 10.23.100.0 -iface tun0 add net 10.23.100.0: gateway tun0 2025-10-20 13:43:42 Initialization Sequence Completed If you have any thought about it or something to suggest (or some particular test) please feel free to share http://gerrit.openvpn.net/c/openvpn/+/721/comment/b2bc803a_7e364e02?usp=email : PS11, Line 1600: && !( (r4->flags & RT_METRIC_DEFINED) && r4->metric == 0 ) ) > how does the metric play into needing a gateway or not? Done http://gerrit.openvpn.net/c/openvpn/+/721/comment/2a5d88e2_1d00ff0a?usp=email : PS11, Line 1607: return true; > There should at least be some idea/comment in the source code as well. […] Done http://gerrit.openvpn.net/c/openvpn/+/721/comment/85295ff5_ccdfe664?usp=email : PS11, Line 1898: } > Has this been tested on Open and NetBSD? it was already tested from the first patch but i retested the latest patch on dradonfly 6.4.2, openbsd 7.7, freebsd 14.3, netbsd 10.0 and MacOS sonoma http://gerrit.openvpn.net/c/openvpn/+/721/comment/0b6b4458_7d49c544?usp=email : PS11, Line 2010: { > I think this duplicates the code that was publicly accessible in > https://gerrit.openvpn. […] Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/721?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I87777e74b1fd34781e1d72c9f994eb84f39d800c Gerrit-Change-Number: 721 Gerrit-PatchSet: 12 Gerrit-Owner: mrbff <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-CC: ordex <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Attention: ordex <[email protected]> Gerrit-Comment-Date: Tue, 21 Oct 2025 14:10:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: plaisthos <[email protected]> Comment-In-Reply-To: ordex <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
