Yeah, having a "prompt_len" field in there for the unlikely case of having
a prompt that is not 0-terminated, and then all the backends just do not
use this at all - functions should have been named ..._ex(), to be prepared
for all eventualities...
Stared at code, change was less intrusive than I expected when seeing
"oh, so many files", and is very straightforward.
Smoke-tested with a corp VPN profile which has a crypted privkey plus
username + password, and that all still works.
Your patch has been applied to the master branch.
commit aea7727f2de8c4f34d71a8c14756bdf395cb5f2f
Author: Frank Lichtenheld
Date: Fri Oct 10 11:47:44 2025 +0200
console: Simplify query_user_add interface
Signed-off-by: Frank Lichtenheld <[email protected]>
Acked-by: Gert Doering <[email protected]>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1216
Message-Id: <[email protected]>
URL: https://sourceforge.net/p/openvpn/mailman/message/59244794/
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
