Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1168?usp=email )
The change is no longer submittable: Code-Review is unsatisfied now. Change subject: Enable -Wconversion -Wno-sign-conversion by default ...................................................................... Patch Set 13: Code-Review-2 (1 comment) Patchset: PS13: This fails building GHA, I guess because something-pkcs11 is not yet guarded https://github.com/cron2/openvpn/actions/runs/17972875656/job/51119449471 ``` CC pkcs11_testdriver-mock_get_random.o 284 test_pkcs11.c: In function ‘test_pkcs11_ids’: 285 test_pkcs11.c:381:57: error: conversion from ‘size_t’ {aka ‘long unsigned int’} to ‘int’ may change value [-Werror=conversion] 286 381 | int derlen = openvpn_base64_decode(base64, der, strlen(base64)); 287 | ^~~~~~~~~~~~~~ 288 CC ../../../src/openvpn/pkcs11_testdriver-xkey_helper.o 289 CC ../../../src/openvpn/pkcs11_testdriver-xkey_provider.o`` ``` -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1168?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Iad5b00c35a1f1993b1fa99e8b945ab17b230ef59 Gerrit-Change-Number: 1168 Gerrit-PatchSet: 13 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Wed, 24 Sep 2025 10:07:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
