cron2 has uploaded a new patch set (#2) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1281?usp=email )
Change subject: ssl_util: Fix conversion warning in get_num_elements ...................................................................... ssl_util: Fix conversion warning in get_num_elements Just use correct type. Change-Id: I2d1fbe7ec080beb931253d09c1b5227e9bf4e756 Signed-off-by: Frank Lichtenheld <[email protected]> Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1281 Message-Id: <[email protected]> URL: https://www.mail-archive.com/[email protected]/msg33421.html Signed-off-by: Gert Doering <[email protected]> --- M src/openvpn/ssl_util.c 1 file changed, 2 insertions(+), 11 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/81/1281/2 diff --git a/src/openvpn/ssl_util.c b/src/openvpn/ssl_util.c index 50e8c03..fb7cf3e 100644 --- a/src/openvpn/ssl_util.c +++ b/src/openvpn/ssl_util.c @@ -290,21 +290,16 @@ return NULL; } -#if defined(__GNUC__) || defined(__clang__) -#pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wconversion" -#endif - int get_num_elements(const char *string, char delimiter) { - int string_len = strlen(string); + const size_t string_len = strlen(string); ASSERT(0 != string_len); int element_count = 1; /* Get number of ciphers */ - for (int i = 0; i < string_len; i++) + for (size_t i = 0; i < string_len; i++) { if (string[i] == delimiter) { @@ -314,7 +309,3 @@ return element_count; } - -#if defined(__GNUC__) || defined(__clang__) -#pragma GCC diagnostic pop -#endif -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1281?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I2d1fbe7ec080beb931253d09c1b5227e9bf4e756 Gerrit-Change-Number: 1281 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
