Attention is currently required from: cron2, flichtenheld, mrbff, plaisthos.
ordex has posted comments on this change by mrbff. ( http://gerrit.openvpn.net/c/openvpn/+/1245?usp=email ) Change subject: PUSH_UPDATE: disabling PUSH_UPDATE server and client if DCO is enabled ...................................................................... Patch Set 5: (3 comments) File src/openvpn/push.c: http://gerrit.openvpn.net/c/openvpn/+/1245/comment/cff164a5_fe297422?usp=email : PS5, Line 1117: msg(M_WARN, "WARN: PUSH_UPDATE messages cannot currently be received while DCO is enabled, ignoring." I'd reword: "be received while.." -> "be processed in client mode while.." http://gerrit.openvpn.net/c/openvpn/+/1245/comment/c79ce5b0_07a07e3b?usp=email : PS5, Line 1118: " To receive PUSH_UPDATE messages, be sure to use the --disable-dco option."); I'd reword: "To receive.." -> "To be able to process.." File src/openvpn/push_util.c: http://gerrit.openvpn.net/c/openvpn/+/1245/comment/e9277b6d_e934a501?usp=email : PS5, Line 301: if (dco_enabled(&m->top.options)) Why not doing this check only once at the beginning of `send_push_update()` ? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1245?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ibe78949435bb2f26ad68301e2710321bf37c9486 Gerrit-Change-Number: 1245 Gerrit-PatchSet: 5 Gerrit-Owner: mrbff <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-CC: ordex <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: cron2 <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Attention: mrbff <[email protected]> Gerrit-Comment-Date: Wed, 08 Oct 2025 07:42:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
