This is not the first function we wrap in openvpn_...(), and it's not
truly making our code more easy to understand at first - but it saves
needless casts all over the place, which *does* make it better.

Stared at the code, ran a full client/server test run on Linux
(ran it together with the two following socks/proxy patches, excercising
all the socket and the proxy code), works.

Test built on mingw "no errors".

Your patch has been applied to the master branch.

commit 42459e22c9ccf3488609338c9e4e4a9bd845e602
Author: Frank Lichtenheld
Date:   Thu Oct 16 12:17:16 2025 +0200

     socket: Wrap winsock functions to avoid common conversion warnings

     Signed-off-by: Frank Lichtenheld <[email protected]>
     Acked-by: Gert Doering <[email protected]>
     Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1277
     Message-Id: <[email protected]>
     URL: https://sourceforge.net/p/openvpn/mailman/message/59247452/
     Signed-off-by: Gert Doering <[email protected]>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to