Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1272?usp=email
to review the following change.
Change subject: Silence unhelpful compiler truncation warning with bigger buffer
......................................................................
Silence unhelpful compiler truncation warning with bigger buffer
On the more recent mingw compilers (homebrew mingw 13.0.0, GCC 15.2.0) the
compiler complains about a potential truncation in these two places.
src/openvpn/tun.c:3806:57:
error: '%s' directive output may be truncated writing up
to 255 bytes into a region of size 178
[-Werror=format-truncation=]
This not very helpful but just increasing the buffer sizes makes the warning
go away.
Change-Id: I54b11a5540fb236580a3b80c6d1e8678b24bd852
Signed-off-by: Arne Schwabe <[email protected]>
---
M src/openvpn/tun.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/72/1272/1
diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c
index 06b7ae5..fc06b16 100644
--- a/src/openvpn/tun.c
+++ b/src/openvpn/tun.c
@@ -3784,7 +3784,7 @@
while (true)
{
char enum_name[256];
- char unit_string[256];
+ char unit_string[512];
HKEY unit_key;
char component_id_string[] = "ComponentId";
char component_id[256];
@@ -3895,7 +3895,7 @@
while (true)
{
char enum_name[256];
- char connection_string[256];
+ char connection_string[512];
HKEY connection_key;
WCHAR name_data[256];
DWORD name_type;
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1272?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I54b11a5540fb236580a3b80c6d1e8678b24bd852
Gerrit-Change-Number: 1272
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
