Attention is currently required from: flichtenheld, plaisthos.

stipa has posted comments on this change by flichtenheld. ( 
http://gerrit.openvpn.net/c/openvpn/+/1262?usp=email )

Change subject: socks: Fix conversion warnings with MinGW
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1:
I checked the Winsock API and indeed type conversion looks correct.

I was a bit puzzled by "NB" in comment (what is that?) but not too much to not 
to ack it.

I didn't test it - only compiled with msvc cl/clang.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1262?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I977bab08cb614c2d59c34ceebc112f3add9bd168
Gerrit-Change-Number: 1262
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-Reviewer: stipa <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Fri, 10 Oct 2025 07:58:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to