"Because it makes sense". Magic numbers are never good.
Verified that the new constants match the old magic number (not checked
the RFC, but "the old numbers" are what we had, so those should be fine).
Your patch has been applied to the master branch.
commit e03d53842b5494d8caf19fc47ea788a32a3544c7
Author: Frank Lichtenheld
Date: Sat Oct 11 10:22:26 2025 +0200
dhcp: Replace DHCP Option types with defines
Signed-off-by: Frank Lichtenheld <[email protected]>
Acked-by: Gert Doering <[email protected]>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1266
Message-Id: <[email protected]>
URL: https://sourceforge.net/p/openvpn/mailman/message/59245241/
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel