This needed a few rounds on my end - the patch adds a new file that
consists of "CR+NL" line endings, and "git am --whitespace=fix"
helpfully fixed that... pushing to GHA still worked(!), seems the
test magic running this on a windows machine restored the line endings
- my own tests on FreeBSD and Linux failed. Applied with "=ignore",
and magic!
============================================================================
Testsuite summary for OpenVPN 2.7_beta2 Unit-Tests
============================================================================
# TOTAL: 15
# PASS: 15
(it's not possible to run this test driver "just so" from the command
line, though :( ).
Github action also still succeeds, BB all green, and the changes look
good and tests for the user/password parsing are most welcome - we've
had our share of bugs in this, so, more tests, less surprises.
Your patch has been applied to the master branch.
commit e7fdde7cb8d39a51a4a38b0d16f23a18d086cfe2
Author: Frank Lichtenheld
Date: Fri Oct 10 23:11:47 2025 +0200
test_user_pass: Check fatal errors for empty username/password
Signed-off-by: Frank Lichtenheld <[email protected]>
Acked-by: Gert Doering <[email protected]>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/474
Message-Id: <[email protected]>
URL: https://sourceforge.net/p/openvpn/mailman/message/59245149/
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
