Changes makes sense. BB happy (though the t-client tests do not
really excercise just these options). I have smoke tested --mssfix
(because I had a test bed around from the checksum tests), works, gives
nice error messages and does the job for acceptable values.
MaxF has done the initial review, and had doubts about changing the
behaviour of "max-routes-per-client 0" - which used to be
"silent upgrade to 1", and now "error".
Given that this is one of the very obscure openvpn options anyway, the
chance that anyone is being hit by this is fairly small - and if it
hits, their config was (silently) broken before. So, +2 from me, in
it goes.
Your patch has been applied to the master branch.
commit 7579749fee05ee8a06dd6169396fb60f7558925a
Author: Frank Lichtenheld
Date: Thu Oct 9 22:59:46 2025 +0200
options: Review use of positive_atoi vs atoi_constrained
Signed-off-by: Frank Lichtenheld <[email protected]>
Acked-by: Gert Doering <[email protected]>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1153
Message-Id: <[email protected]>
URL: https://sourceforge.net/p/openvpn/mailman/message/59244617/
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
