Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1193?usp=email )
Change subject: Allowing installing FreeBSD routes with interface instead of next-hop ...................................................................... Patch Set 3: (1 comment) File src/openvpn/networking_freebsd.c: http://gerrit.openvpn.net/c/openvpn/+/1193/comment/5c8a40a2_8ceda728 : PS3, Line 23: /* if gw is 0 (=0.0.0.0), which is not a valid gateway, > are you passing in NULL or "a pointer to 0.0.0. […] ``` /* if we have a gateway (GW != NULL) install route to gateway IP * if not, install "connected" route to interface (required for ifconfig-push IPs) */ ``` something like this? I think this would help understanding the code and be in line with the `if(gw)...` -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1193?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I88e16e15fad065cb310d38f09924053efc3a6ce5 Gerrit-Change-Number: 1193 Gerrit-PatchSet: 3 Gerrit-Owner: plaisthos <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Sun, 28 Sep 2025 11:24:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 <[email protected]> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
