Attention is currently required from: ordex, plaisthos.

flichtenheld has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/1110?usp=email )

Change subject: Introduce msglvl_t to unify msglevel type handling
......................................................................


Patch Set 16:

(1 comment)

File src/openvpn/error.c:

http://gerrit.openvpn.net/c/openvpn/+/1110/comment/e7d1179f_51d3b84a :
PS16, Line 104: set_debug_level(const int level, const unsigned int flags)
> why not turning this into msglvl_t too? […]
I considered it, but then decided to leave it as is. I had to draw a boundary 
somewhere. We could definitely change it in a separate commit but this one is 
big enough as it is.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1110?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Id492cb774c6d022d06bb3cf5fec2a4bdd410e619
Gerrit-Change-Number: 1110
Gerrit-PatchSet: 16
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: cron2 <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-CC: ordex <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: ordex <[email protected]>
Gerrit-Comment-Date: Thu, 18 Sep 2025 09:44:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: ordex <[email protected]>
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to