Attention is currently required from: flichtenheld, plaisthos, selvanair. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1188?usp=email )
Change subject: openvpnserv: Fix writing messages to the event log ...................................................................... Patch Set 2: (2 comments) File src/openvpnserv/common.c: http://gerrit.openvpn.net/c/openvpn/+/1188/comment/faf6c002_b6bdf61f : PS1, Line 209: NULL, error, MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT), (LPTSTR)&tmp, 0, NULL); > Explict use of the unicode version "FormatMessageW" preferred. Acknowledged http://gerrit.openvpn.net/c/openvpn/+/1188/comment/33eaf24d_50732a8f : PS1, Line 228: buf[_countof(buf) - 1] = L'\0'; > Previously we removed openvp_swprintf etc. […] JFTR: only MSFT version of swprintf guarantees NULL termination. Other versions won't write anything (and won't terminate) if the string doesn't fit. OTOH, we build releases with MSVC and in any case we nowadays use MSFT implementation (ucrtbase.dll) from OS. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1188?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I423c9880def0eb479abb72bef2e8034a73cf5905 Gerrit-Change-Number: 1188 Gerrit-PatchSet: 2 Gerrit-Owner: stipa <lstipa...@gmail.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-CC: selvanair <selva.n...@gmail.com> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: selvanair <selva.n...@gmail.com> Gerrit-Comment-Date: Tue, 16 Sep 2025 07:10:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: selvanair <selva.n...@gmail.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
