Change looks reasonable, MaxF has ACKed it, the BBs confirm nothing breaks,
and I have actually very lightly tested it (--reneg-pkts, --reneg-bytes,
with easily-achievable values - watch out for DCO...).
For values >2^63, strtoll() truncates to 9223372036854775808 - which
is documented and tested for. We do not error on this today, but
for what it's used for, clamping is probably fine (because larger
numbers make even less sense).
Your patch has been applied to the master branch.
This time, mail-archive.org (for a change) actually acknowledges existance
of the mail with the patch... yay.
commit 10c42c7407ccc467f75e25f752275e412ff35a91
Author: Frank Lichtenheld
Date: Thu Sep 11 22:15:00 2025 +0200
options: Factor out usages of strtoll and atoll
Signed-off-by: Frank Lichtenheld <fr...@lichtenheld.com>
Acked-by: MaxF <m...@max-fillinger.net>
URL: https://gerrit.openvpn.net/c/openvpn/+/1154
Message-Id: <20250911201505.25582-1-g...@greenie.muc.de>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32858.html
Signed-off-by: Gert Doering <g...@greenie.muc.de>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
