cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1177?usp=email )
Change subject: push-update-server: comment about buf_string_compare_advance() usage in send_single_push_update() ...................................................................... push-update-server: comment about buf_string_compare_advance() usage in send_single_push_update() Change-Id: I73f8ad9bf105920f4bde357ea9dcf0e485f3f3cb Signed-off-by: Marco Baffo <ma...@mandelbit.com> Acked-by: Frank Lichtenheld <fr...@lichtenheld.com> Message-Id: <20250912131519.43222-1-fr...@lichtenheld.com> URL: https://sourceforge.net/p/openvpn/mailman/message/59232447/ URL: https://gerrit.openvpn.net/c/openvpn/+/1177 Signed-off-by: Gert Doering <g...@greenie.muc.de> --- M src/openvpn/push_util.c 1 file changed, 4 insertions(+), 0 deletions(-) diff --git a/src/openvpn/push_util.c b/src/openvpn/push_util.c index bd3992b..f7a4fca 100644 --- a/src/openvpn/push_util.c +++ b/src/openvpn/push_util.c @@ -161,6 +161,10 @@ * will not be routed towards the client. * For the same reason we later update the vhash too in * `send_push_update()` function. + * Using `buf_string_compare_advance()` we mimic the behavior + * inside `process_incoming_push_msg()`. However, we don't need + * to check the return value here because we just want to `advance`, + * meaning we skip the `push_update_cmd' we added earlier. */ buf_string_compare_advance(&msgs[i], push_update_cmd); if (process_incoming_push_update(c, pull_permission_mask(c), option_types_found, &msgs[i], true) == PUSH_MSG_ERROR) -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1177?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I73f8ad9bf105920f4bde357ea9dcf0e485f3f3cb Gerrit-Change-Number: 1177 Gerrit-PatchSet: 4 Gerrit-Owner: mrbff <ma...@mandelbit.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-MessageType: merged
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
