Attention is currently required from: plaisthos, stipa.

flichtenheld has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/1183?usp=email )

Change subject: win: replace wmic invocation with powershell
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

File src/openvpn/tun.c:

http://gerrit.openvpn.net/c/openvpn/+/1183/comment/6b713ade_eaa76213 :
PS1, Line 395:                 "%s%s -NoProfile -NonInteractive -Command 
Set-DnsClient -InterfaceIndex %ld -ConnectionSpecificSuffix '%s'",
adapter_index is DWORD, so please use %lu


File src/openvpnserv/interactive.c:

http://gerrit.openvpn.net/c/openvpn/+/1183/comment/ea152e05_3903c18c :
PS1, Line 1168: NoProfile
NET_IFINDEX is ULONG, so please use %lu



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1183?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: release/2.6
Gerrit-Change-Id: Iff2f4ea677fe2d88659d7814dab0f792f5004fb3
Gerrit-Change-Number: 1183
Gerrit-PatchSet: 1
Gerrit-Owner: stipa <lstipa...@gmail.com>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: stipa <lstipa...@gmail.com>
Gerrit-Comment-Date: Fri, 12 Sep 2025 14:05:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to