I don't have proof of it but I think I was being hit with this accept issue as I've been running and testing OpenVPN in TCP client/server modes only. I'll wait for this to hit master and rebase my PRs - thanks :)
On Thu, Sep 11, 2025 at 10:23 AM its_Giaan (Code Review) <ger...@openvpn.net> wrote: > Attention is currently required from: flichtenheld, plaisthos. > > its_Giaan *uploaded patch set #3* to this change. > > View Change <http://gerrit.openvpn.net/c/openvpn/+/1174?usp=email> > > Multi-socket win: avoid repeated socket_set() > > On Windows, multi-socket support failed with > mixed protocols due to repeated socket_set() > calls, which caused accept() to be triggered > before having an event to process. > This fix skips socket_set() calls for > non-UDP sockets in MODE_SERVER inside > multi_io_process_flags(). > > Change-Id: Ia389fcec50fb2bbc0aa5ad41a2c23c17c04e6e9b > Signed-off-by: Gianmarco De Gregori <gianma...@mandelbit.com> > --- > M src/openvpn/forward.c > 1 file changed, 6 insertions(+), 1 deletion(-) > > git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/74/1174/3 > > diff --git a/src/openvpn/forward.c b/src/openvpn/forward.c > index 03b6a0c..5d22fa3 100644 > --- a/src/openvpn/forward.c > +++ b/src/openvpn/forward.c > @@ -2121,10 +2121,15 @@ > > /* > * Configure event wait based on socket, tuntap flags. > + * (for TCP server sockets this happens in > + * socket_set_listen_persistent()). > */ > for (int i = 0; i < c->c1.link_sockets_num; i++) > { > - socket_set(c->c2.link_sockets[i], es, socket, > &c->c2.link_sockets[i]->ev_arg, NULL); > + if ((c->options.mode != MODE_SERVER) || > (proto_is_dgram(c->c2.link_sockets[i]->info.proto))) > + { > + socket_set(c->c2.link_sockets[i], es, socket, > &c->c2.link_sockets[i]->ev_arg, NULL); > + } > } > > tun_set(c->c1.tuntap, es, tuntap, (void *)tun_shift, NULL); > > To view, visit change 1174 > <http://gerrit.openvpn.net/c/openvpn/+/1174?usp=email>. To unsubscribe, > or for help writing mail filters, visit settings > <http://gerrit.openvpn.net/settings>. > Gerrit-Project: openvpn > Gerrit-Branch: master > Gerrit-Change-Id: Ia389fcec50fb2bbc0aa5ad41a2c23c17c04e6e9b > Gerrit-Change-Number: 1174 > Gerrit-PatchSet: 3 > Gerrit-Owner: its_Giaan <gianma...@mandelbit.com> > Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> > Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> > Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> > Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> > Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> > Gerrit-MessageType: newpatchset > _______________________________________________ > Openvpn-devel mailing list > Openvpn-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/openvpn-devel >
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
