Unit tests are good, especially if an integer-related change to one of the slightly more obscure functions is coming up :-) (and indeed, this function was so much nicer when it still had 32-bit additions...)
This patch does not add or change code in "openvpn itself", just adds a unit test module, based on the new socket_util.c in the previous commit. So not much to test, except look at BB (all green in v4) and test on GHA (also all green). Your patch has been applied to the master branch. commit 10d64c184404c532fe0861d5c57fb1613a608d4c Author: Frank Lichtenheld Date: Sun Aug 31 17:11:26 2025 +0200 Add new unit test module test_socket Signed-off-by: Frank Lichtenheld <fr...@lichtenheld.com> Acked-by: Gert Doering <g...@greenie.muc.de> Message-Id: <20250831151133.25684-1-g...@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32723.html Signed-off-by: Gert Doering <g...@greenie.muc.de> -- kind regards, Gert Doering _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel