Attention is currently required from: cron2, flichtenheld, plaisthos, stipa.
mrbff has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/869?usp=email ) Change subject: PUSH_UPDATE message sender: enabling the server to send PUSH_UPDATE control messages ...................................................................... Patch Set 25: (1 comment) Patchset: PS23: > About the first point, i fixed the restarting in the server but the "sending > a wrong message and con […] * Regarding the second point, the odd timing it's because the message is just enqueued (by `send_control_channel_string()`) but it gets "on the wire" only when `tls_process()` is finally called, so you could get from less than 1 up to around 10 seconds of latency from when the command is injected through management to when the packet leave the server instance. * Regarding 3rd point instead, yes, the `/0` was an issue, i was misusing a function's parameter. For the push-update usage i think the only 'correct' way of pushing an ifconfig option should be something like `ifconfig 10.204.2.47 255.255.255.0` (shouldn't we use it only in subnet mode?) with the pushed ip in the same subnet of the server virtual ip, in this case `10.204.2.45/24` for example (or do we want to update the server ip too?) . I mean, this look to me the only practical use case but maybe i'm missing something, if so please tell me. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/869?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie82bcc7a8e583de9156b185d71d1a323ed8df3fc Gerrit-Change-Number: 869 Gerrit-PatchSet: 25 Gerrit-Owner: mrbff <ma...@mandelbit.com> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: stipa <lstipa...@gmail.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: cron2 <g...@greenie.muc.de> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: stipa <lstipa...@gmail.com> Gerrit-Comment-Date: Tue, 26 Aug 2025 15:31:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 <g...@greenie.muc.de> Comment-In-Reply-To: mrbff <ma...@mandelbit.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
