Attention is currently required from: cron2, flichtenheld, plaisthos, stipa.
mrbff has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/869?usp=email ) Change subject: PUSH_UPDATE message sender: enabling the server to send PUSH_UPDATE control messages ...................................................................... Patch Set 17: (12 comments) File doc/management-notes.txt: http://gerrit.openvpn.net/c/openvpn/+/869/comment/33d4ba61_04cc0d55 : PS16, Line 1075: > I do question whether this is a reasonable approach, to have "by cn" and "by > addr" functions, that a […] i mostly followed the `kill` command, but yes it is the second one. File src/openvpn/manage.c: http://gerrit.openvpn.net/c/openvpn/+/869/comment/183ce8a9_448ff5ac : PS16, Line 1362: } > I bet there are more elegant and less repetitive ways to do 4 different `if > (status) print(SUCCESS!) […] Done File src/openvpn/push.h: http://gerrit.openvpn.net/c/openvpn/+/869/comment/940bc697_89ca7f9f : PS16, Line 54: > This does confuse me a bit. […] you can get the cid only from management, but theoretically the rest could be used by other functions in the future File src/openvpn/push_util.c: http://gerrit.openvpn.net/c/openvpn/+/869/comment/ccbe9b3d_34774f2d : PS16, Line 66: /* Allocate memory and asseble the final message */ > typo Done http://gerrit.openvpn.net/c/openvpn/+/869/comment/a9514c2d_3d9f4c1f : PS16, Line 82: } > it might increase readability to juse use `snprintf( ... […] Done http://gerrit.openvpn.net/c/openvpn/+/869/comment/bc395641_798e9979 : PS16, Line 122: msgs[im] = forge_msg(str, ",push-continuation 2", gc); > I do wonder if this can be done without modifying the string, so getting rid > of the `strdup()` requi […] Acknowledged http://gerrit.openvpn.net/c/openvpn/+/869/comment/9e0a4d3f_be2fdaaa : PS16, Line 143: /* It actually send the already divided messagge to one single client */ > This comment needs a visit from the grammar police ;-) […] Done http://gerrit.openvpn.net/c/openvpn/+/869/comment/c617f505_475db955 : PS16, Line 158: buf_write(&buf, msgs[i], strlen(msgs[i])); > If you want to have the message in a `buf` here, you could have `forge_msg()` > just use `buf_printf() […] ok, working on it http://gerrit.openvpn.net/c/openvpn/+/869/comment/ac640134_01fb9aae : PS16, Line 165: /* After sending the control message, we update the options server-side in the client's context */ > Can you extend the comment a bit on why this is needed? I assume (which > might or might not be a bad […] Done http://gerrit.openvpn.net/c/openvpn/+/869/comment/7a73548b_cfd887a6 : PS16, Line 204: if (!message_splitter(gc_strdup(msg, &gc), msgs, &gc, safe_cap)) > Please do not call `strdup()` in a function call... […] Done http://gerrit.openvpn.net/c/openvpn/+/869/comment/4e68ba97_68899c76 : PS16, Line 239: > how can we ever end here if ENABLE_MANAGEMENT is not defined? Except for the > unit test, there is no […] We can't now, yes, but the function could be used somewhere else in the future http://gerrit.openvpn.net/c/openvpn/+/869/comment/d6fc2d7c_558c5256 : PS16, Line 305: RETURN_UPDATE_STATUS(n_sent); > so here we have this nice if/else macro that manage.c could use :-)... […] i need to do the lookup anyway in send_push_update(), so it would duplicate code with no good reason i think, but i can use the macro anyway, np -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/869?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie82bcc7a8e583de9156b185d71d1a323ed8df3fc Gerrit-Change-Number: 869 Gerrit-PatchSet: 17 Gerrit-Owner: mrbff <ma...@mandelbit.com> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: stipa <lstipa...@gmail.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: cron2 <g...@greenie.muc.de> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: stipa <lstipa...@gmail.com> Gerrit-Comment-Date: Thu, 24 Jul 2025 08:21:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 <g...@greenie.muc.de> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
