Attention is currently required from: flichtenheld, plaisthos, stipa.

cron2 has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/903?usp=email )

Change subject: Make recursive routing check more fine-grained
......................................................................


Patch Set 1: Code-Review-2

(2 comments)

Patchset:

PS1:
only looked very briefly, but we must avoid doing extra mallocs (gc_arena) for 
every single packet


File src/openvpn/forward.c:

http://gerrit.openvpn.net/c/openvpn/+/903/comment/507ab496_f0c079fb :
PS1, Line 1389:     struct gc_arena gc = gc_new();
this is in the "for every packet" path, so we should not allocate gc_arenas if 
we do not need them (which is why it was only in the "print" part so far)



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/903?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6841e2f2a85275254a04e2d8ae3defe4420db8f6
Gerrit-Change-Number: 903
Gerrit-PatchSet: 1
Gerrit-Owner: stipa <lstipa...@gmail.com>
Gerrit-Reviewer: cron2 <g...@greenie.muc.de>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Attention: stipa <lstipa...@gmail.com>
Gerrit-Comment-Date: Thu, 06 Mar 2025 14:42:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to