cron2 has uploaded a new patch set (#2) to the change originally created by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/900?usp=email )
The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: dco-win: simplify control packets prepend code ...................................................................... dco-win: simplify control packets prepend code Eliminate unneeded temporary struct sockaddr_in buffer. Change-Id: Ie57f7b11157ab5ca8ff01e1c4f03a308117ff937 Signed-off-by: Lev Stipakov <l...@openvpn.net> Acked-by: Gert Doering <g...@greenie.muc.de> Message-Id: <20250220074327.24922-1-g...@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg30942.html Signed-off-by: Gert Doering <g...@greenie.muc.de> --- M src/openvpn/socket.h 1 file changed, 2 insertions(+), 6 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/00/900/2 diff --git a/src/openvpn/socket.h b/src/openvpn/socket.h index c370f2c..2c33319 100644 --- a/src/openvpn/socket.h +++ b/src/openvpn/socket.h @@ -1125,15 +1125,11 @@ { if (to->dest.addr.sa.sa_family == AF_INET) { - struct sockaddr_in sa; - memcpy(&sa, &to->dest.addr.in4, sizeof(sa)); - buf_write_prepend(buf, &sa, sizeof(sa)); + buf_write_prepend(buf, &to->dest.addr.in4, sizeof(struct sockaddr_in)); } else { - struct sockaddr_in6 sa; - memcpy(&sa, &to->dest.addr.in6, sizeof(sa)); - buf_write_prepend(buf, &sa, sizeof(sa)); + buf_write_prepend(buf, &to->dest.addr.in6, sizeof(struct sockaddr_in6)); } } -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/900?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie57f7b11157ab5ca8ff01e1c4f03a308117ff937 Gerrit-Change-Number: 900 Gerrit-PatchSet: 2 Gerrit-Owner: stipa <lstipa...@gmail.com> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-MessageType: newpatchset
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
