So, finally, on v20 :-)
This has received quite a bit of stare-at-code review, and I also tested
this on a windows VM with a mingw-bult openvpn.exe, using Lev's most
recent DCO driver. "It works, what shall I say" ;-)
#815 on itself works, but lacks --timeout handling - so if a client
disconnects (without sending EEN), kernel can not notify userland and
the peer will "stick". #816 will add that functionality. Nothing
will crash or misbehave in other ways, though.
NOTE: for server functionality, one needs to turn on IP forwarding on
the windows system ("as usual"). For IPv4 this is a registry key + reboot,
for IPv6 it's a magic netsh call (and no reboot, and after a reboot the
netsh setting seems to return to "disabled"). This is all a bit ugly, so
we need to see if we can make it better for the user (or at least have more
documentation in our shiny new wiki).
NOTE2: on commit, uncrustify complains about ovpn_dco_win.h - which I have
ignored, as this is "import an external .h file describing the API", as
for the Linux file. dev-tools/special-files.list has the appropriate
exclude, but the commit-hook does not know that.
Your patch has been applied to the master branch.
commit 1625d927fc79e2926015ded06a01fd8e460a4bc7
Author: Lev Stipakov
Date: Wed Feb 19 22:54:17 2025 +0100
dco-win: multipeer support
Signed-off-by: Lev Stipakov <[email protected]>
Acked-by: Gert Doering <[email protected]>
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg30935.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
