Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/899?usp=email
to review the following change.
Change subject: add more (void) to windows specific function prototypes and
declarations
......................................................................
add more (void) to windows specific function prototypes and declarations
Change-Id: I1a9738ad73c79661a8beb4d9881eba0b4d3aea53
Signed-off-by: Gert Doering <g...@greenie.muc.de>
---
M src/openvpn/win32.c
M src/openvpnserv/common.c
M src/openvpnserv/service.c
M src/openvpnserv/service.h
4 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/99/899/1
diff --git a/src/openvpn/win32.c b/src/openvpn/win32.c
index 86556a8..edac71e 100644
--- a/src/openvpn/win32.c
+++ b/src/openvpn/win32.c
@@ -103,7 +103,7 @@
* Set OpenSSL environment variables to a safe directory
*/
static void
-set_openssl_env_vars();
+set_openssl_env_vars(void);
void
init_win32(void)
@@ -1518,7 +1518,7 @@
}
static void
-set_openssl_env_vars()
+set_openssl_env_vars(void)
{
const WCHAR *ssl_fallback_dir = L"C:\\Windows\\System32";
diff --git a/src/openvpnserv/common.c b/src/openvpnserv/common.c
index a88a724..74bec6e 100644
--- a/src/openvpnserv/common.c
+++ b/src/openvpnserv/common.c
@@ -181,7 +181,7 @@
LPCTSTR
-GetLastErrorText()
+GetLastErrorText(void)
{
DWORD error;
static TCHAR buf[256];
diff --git a/src/openvpnserv/service.c b/src/openvpnserv/service.c
index 054fc5f..84fd11a 100644
--- a/src/openvpnserv/service.c
+++ b/src/openvpnserv/service.c
@@ -54,7 +54,7 @@
}
static int
-CmdInstallServices()
+CmdInstallServices(void)
{
SC_HANDLE service;
SC_HANDLE svc_ctl_mgr;
@@ -146,7 +146,7 @@
static int
-CmdRemoveServices()
+CmdRemoveServices(void)
{
SC_HANDLE service;
SC_HANDLE svc_ctl_mgr;
diff --git a/src/openvpnserv/service.h b/src/openvpnserv/service.h
index da20433..c5f587b 100644
--- a/src/openvpnserv/service.h
+++ b/src/openvpnserv/service.h
@@ -86,7 +86,7 @@
BOOL ReportStatusToSCMgr(SERVICE_STATUS_HANDLE service, SERVICE_STATUS
*status);
-LPCTSTR GetLastErrorText();
+LPCTSTR GetLastErrorText(void);
DWORD MsgToEventLog(DWORD flags, LPCTSTR lpszMsg, ...);
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/899?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I1a9738ad73c79661a8beb4d9881eba0b4d3aea53
Gerrit-Change-Number: 899
Gerrit-PatchSet: 1
Gerrit-Owner: cron2 <g...@greenie.muc.de>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-MessageType: newchange
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
