Attention is currently required from: flichtenheld, its_Giaan, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/880?usp=email )
Change subject: mroute/management: fix unitialized variable (UNINIT) ...................................................................... Patch Set 1: Code-Review-1 (3 comments) Patchset: PS1: close. Please extend doc/management-notes.txt with the new syntax as well. File src/openvpn/manage.c: http://gerrit.openvpn.net/c/openvpn/+/880/comment/89921c64_ce4843fe : PS1, Line 573: port, p3); not sure we should use `p3` here (what if a user sends 'foo'?). Also, proto traditionall gets printed in front ("tcp:10.0.0.3:1194") so we shouldn't start printing it at the end here... File src/openvpn/mroute.c: http://gerrit.openvpn.net/c/openvpn/+/880/comment/75d367d4_1b83c9e4 : PS1, Line 441: if ((maddr.type & MR_WITH_PROTO)) double `(())` braces... -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/880?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I4be0ff4d308213d2ef8ba66bd3178eee1f60fff1 Gerrit-Change-Number: 880 Gerrit-PatchSet: 1 Gerrit-Owner: its_Giaan <gianma...@mandelbit.com> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: its_Giaan <gianma...@mandelbit.com> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Tue, 28 Jan 2025 14:15:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
