Another patch in the series that doesn't actually change anything yet,
but builds infrastructure.  It comes with a fairly extensive unit test,
which passes :-)

The changes look reasonable to me, and have a +2 from MaxF in Gerrit
(who understands crypto much better).

As the patch actually does add a (not yet used) branch to the regular
AEAD cipher path and also changes the "impl_iv_offset" stuff, I stared
a bit harder, and subjected everything to the client/server testbed -
and nothing breaks in the old packet format.

Two comments have been grammar fixed as instructed ("the the -> the" and
"will will -> will").

Your patch has been applied to the master branch.

commit 92adbc88b1b37095cebde2a1c5b6ae242f382678
Author: Arne Schwabe
Date:   Thu Jan 9 19:05:37 2025 +0100

     Implement methods to generate and manage OpenVPN Epoch keys

     Signed-off-by: Arne Schwabe <a...@rfc2549.org>
     Acked-by: MaxF <m...@max-fillinger.net>
     Message-Id: <20250109180537.27686-1-g...@greenie.muc.de>
     URL: 
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg30390.html
     Signed-off-by: Gert Doering <g...@greenie.muc.de>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to